Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tooltip window flags #7613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regulus79
Copy link
Contributor

Partially addresses #7145.

This PR changes the window flags of TextFloats (the tooltip things which appear when loading samples/vst/etc) so that they do not stay on top of other windows.

@Rossmaxx Rossmaxx linked an issue Dec 3, 2024 that may be closed by this pull request
@Rossmaxx
Copy link
Contributor

obs-recording-2024-12-12-16-27.mp4

This is how the tooltips work now on my computer. Ignore the vst bug, it's been there for a while.
But at the start, the tooltip appears hidden. Is it intended?

@Rossmaxx
Copy link
Contributor

I'll approve and merge once I get a clarification

@regulus79
Copy link
Contributor Author

the tooltip appears hidden. Is it intended?

This is not intended. But I don't know why it is happening. Given that I can see the faint outline of the tooltip window in your video before it appears probably means that the window has been created, but not yet filled? I don't know if that would be an issue with the windowing system or with Qt.

@Rossmaxx
Copy link
Contributor

Thanks for the explanation. Your suspects of windowing system and qt seems valid. I believe such glitches are found here and there with qt applications on x11. Btw are you on x11 or Wayland?

Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's improving the situation, LGTM.

@regulus79
Copy link
Contributor Author

Btw are you on x11 or Wayland?

I am on Wayland. I actually don't use/have any VSTs so I'm unsure if this particular issue occurs for me, but other times where TextFloats appear (like loading a sample) work fine.

@Rossmaxx
Copy link
Contributor

On sample load, i don't even see a text float

@regulus79
Copy link
Contributor Author

When loading large samples, it appears for a split second.

@michaelgregorius
Copy link
Contributor

To me it does not look like it is really improving the situation. It now just seems to show the message box that asks the user to wait until the action is completed much too late.

It would be better to find out what's causing the current behavior. To me it looks like there's some code that wants to show the message and which start doing so but then something long running is taking over the GUI main thread?

@Rossmaxx
Copy link
Contributor

Rossmaxx commented Dec 19, 2024

@regulus79 how much sense would it make to replace this TextFloat with a QToolTip directly?

@michaelgregorius
Copy link
Contributor

@Rossmaxx, a QToolTip is shown interactively when a user hovers with the mouse over a widget whereas TextFloat is intended to be shown "programmatically". They are really different classes of widgets and should not be mixed IMO.

I have checked VestigeInstrument::loadFile and it is as expected. A call to gui::TextFloat::displayMessage is made and it is then immediately followed by potentially long running actions like loading and initializing the plugin on the GUI main thread. Hence it all happens during the processing of a single event and the text float cannot be shown before the long running actions have performed.

Can someone please check if it gets better with the following adjustment in gui::TextFloat::displayMessage (addition of QCoreApplication::processEvents()):

	if( gui::getGUI() != nullptr )
	{
		tf = gui::TextFloat::displayMessage(
				tr( "Loading plugin" ),
				tr( "Please wait while loading the VST plugin..." ),
				PLUGIN_NAME::getIconPixmap( "logo", 24, 24 ), 0 );
		
		QCoreApplication::processEvents();
	}

I don't any plugin that takes as much time as the one used by @Rossmaxx in the video.

@Rossmaxx
Copy link
Contributor

Or nvm, that regression caught in my video might be the one from #7554, fixed by #7624. I do have to test now again to confirm. If it's so, there's nothing to do, I'll try @michaelgregorius' suggestion too, just to be sure.

The plug-ins i use are 4front e piano and dsk grand piano (IIRC, grabbed them from plugins4free)

@michaelgregorius
Copy link
Contributor

I have just created #7626 which reports other problems with TextFloat under Wayland. Perhaps it is best to implement messages in a different way as proposed in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable this dialog when importing.
3 participants